Missing doc for gpupicker in v8.31.3

I alr have the gpu picker integrated into Seedborn. When updating @babylonjs/core to latest, the gpupicker broke. Managed to track it down to v8.31.3. There seems to be a breaking change but could not find any documentation to update my current setup.

Can someone detail the breaking changes in doc? Thanks in advance.

It seems the issue is caused by the PR I created.
If you could describe the situation where the problem occurs, it would help us resolve it.

Are you using the GPUPicker.defaultRenderMaterial property?
If so, changes to this property may be breaking your code.

I’ve yet to lock down on the issue. All I know is that my thin instances are not highlighting when picked. Comparing to the pgs in this thread, it appears that there might be more than 1 breaking issue.

You can try https://playground.babylonjs.com/?version=8.31.2#NNC5Y2#1 vs
https://playground.babylonjs.com/#NNC5Y2#1 with latest version, the console is logging very different results. Perhaps you can start with this?

1 Like

This doesn’t seem like a breaking change, but rather a bug.
I’m currently looking into the issue.

1 Like

Thanks a lot @noname0310 for looking into it and let us know if we should revert

1 Like

I created a PR to fix the issue. If the issue persists after the merge, please let me know.

1 Like

Just tested against the latest build, thin instance picking is still not registering the correct colorId. As my scene has other settings, I need to do a full dissection for a repro. But my schedule isn’t open till end next wk (earliest), have to kiv for now.

Repro: https://playground.babylonjs.com/#CP2RN9#317

Compare against https://playground.babylonjs.com/?version=8.31.2#CP2RN9#317

Open the console, try to mouseover the area roughly under the lower lip of the mesh. In the latest version, the gpu picker will show pick results but not in the 8.31.2 version. Or you can try picking the tip of the mouth, either way works. I suspect the vat animation isn’t updated in the pick texture.

Took less time than I tot, yay!

1 Like

I’ve identified the cause and am currently considering how best to fix it. Please stay tuned.

Oh, and thank you so much for providing the PG. Thanks to that, I was able to identify the root cause of the problem very fast.

This PR resolves the issue.