Nme bug about screen depth

Lun · August 26, 2022, 11:17am

Babylon.js Playground (babylonjs.com)

I’ trying to make the mesh into gray and keep the background colorful

I use depth to do this

My programer friend said that it seems there is a bug about sampleing. I dont know.

and he made this

QQ图片20220826191602

Babylon.js Playground (babylonjs.com)

carolhmj · August 29, 2022, 3:18pm

I’m sorry, but it’s not clear to me what is the bug here. What is the result you expect on your playground?

Blake · August 29, 2022, 4:26pm

It looks like adding the below code from the second playground is needed for the SceneDepth block to work properly. Then it looks the same as the NME preview.

let sceneDepth = nodeMaterial.getBlockByName("SceneDepth")
sceneDepth._samplerName = "depthSampler"
nodeMaterial.build(true)

carolhmj · August 29, 2022, 4:28pm

oooh thanks for the explanation! @sebavan @Deltakosh any of you have an idea of what might be causing this?

Evgeni_Popov · August 29, 2022, 5:09pm

Instead of hard-setting a value here:

github.com

BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Materials/Node/Blocks/Dual/sceneDepthBlock.ts#L20


      
          import { editableInPropertyPage, PropertyTypeForEdition } from "../../nodeMaterialDecorator";

          import type { Effect } from "../../../effect";

          

          declare type NodeMaterial = import("../../nodeMaterial").NodeMaterial;

          

          /**

           * Block used to retrieve the depth (zbuffer) of the scene

           * @since 5.0.0

           */

          export class SceneDepthBlock extends NodeMaterialBlock {

              private _samplerName = "textureSampler";

              private _mainUVName: string;

              private _tempTextureRead: string;

          

              /**

               * Defines if the depth renderer should be setup in non linear mode

               */

              @editableInPropertyPage("Use non linear depth", PropertyTypeForEdition.Boolean, "ADVANCED", {

                  notifiers: { activatePreviewCommand: true, callback: (scene) => scene.disableDepthRenderer() },

              })

              public useNonLinearDepth = false;

we should generate a temporary name in the _buildBlock function (I can’t do a PR right now).

carolhmj · August 29, 2022, 5:20pm

No worries I can take a look

carolhmj · August 29, 2022, 5:50pm

Would something like this suffice? Generate sampler name in buildBlock by carolhmj · Pull Request #12913 · BabylonJS/Babylon.js (github.com)

Topic		Replies	Views
Issue with depth texture rendering in Babylon Native? Bugs babylon-native	7	881	July 20, 2022
Force field node material using Unity tutorial... Help needed to translate it to Babylon! Questions	4	269	March 25, 2023
Depth rendering incorrect when using CustomMaterial? Questions	1	292	April 14, 2022
NodeMaterial Texture UV Scaling bug Bugs	2	322	April 30, 2021
Node Material Post Processes flashing replace colour at initialisation Questions	10	235	September 23, 2023

Nme bug about screen depth

Related Topics