Please help to enable bvhFileLoader

Bugs
1

The bvhFileLoader isnot included in the babylon.max.js, and I cannot find bvhFileLoader from cdnSnapshot.

I created a PR to enable bvhFIleLoader and fixed a frameRate issue. Please help.

Currently, the bvh cannot load, here is the re-produce playground:

2

cc @sebavan

3

I answered in the PR

4

@xuhuisheng thank you for working on this, please let me know if I can help somehow. I submitted this loader and I may forgot to add something.

I could use the BVH loader but I had to explicitly call registerBuiltInLoaders();

I hope with your changes it becomes even simpler.

Edit: I understood the problem now, I wasn’t using the CDN.

5

Thank you for you job. @yuripourre

I can use bvhFileLoader import bvh file and display animation. But we found three issues.

  1. The bvh codes are not included in distribution file.
  2. The frameRate is wrong, the original frame time value should be divided by one, from 0.03 calculate to 30, otherwise the animation wont play.
  3. The bvhFileLoader is not check the direct load’s header, it will overwrite the default ‘.babylon‘ format import.

The PR passed all the checks, now. Please reivew.

6

Oh, I see. I didn’t realize the bullet point 3 from the PR, thanks for fixing those.

@sebavan already approved your PR, so it should be merged soon.

7

@xuhuisheng Your PR was merged and the Babylon 8.23.0 has your code already.

I tried to run the playground you shared, I can see the ground but no skeleton.

Is there anything missing?

8

@yuripourre

I am sorry for the wrong url. Please use this playground.

2 Likes
9

This is amazing :heart_eyes: thanks for sharing.