Question About .forEach Usage vs for..of in Babylon.js Source Code

Questions
1

In my own projects, I use linting rules like unicorn/no-array-for-each due to the minor performance cost associated with using .forEach compared to for..of.

While reviewing the Babylon.js source code, specifically in assetContainer.ts, I noticed that .forEach is frequently used for traversing arrays. Is there a specific reason for this choice?

For reference, here is a benchmarking comparison of .forEach vs for..of: https://leanylabs.com/blog/js-forEach-map-reduce-vs-for-for_of/.

I’d love to understand the reasoning behind this design decision. Is it for readability, consistency, or something else?

1 Like
2

More of an oversight. We should replace the forEach by for..of (To be honest I did not know about the perf difference)

cc @RaananW who is adding more linting to our codebase

3 Likes
3

You may find this link interesting: GitHub - sindresorhus/eslint-plugin-unicorn: More than 100 powerful ESLint rules

2 Likes
4

I started fixing it:
Replace forEach by for..of for performance reasons by deltakosh · Pull Request #16513 · BabylonJS/Babylon.js

3 Likes