Sandbox/GLTFFileLoader: loading of invalid gltf file never ends

Bugs
, , ,
1

OS: Windows 10
GPU: GTX 1050 2GB
Browser: Firefox 122
Ver: 7.10.2
Url: https://sandbox.babylonjs.com/
Expected: A message popup telling user that the gltf is invalid
Actual: Loading never ends
Screenshot:

sandbox
sandbox752×547 11.5 KB

devtools
devtools904×443 10.5 KB

code
code695×478 21.1 KB

The invalid gltf used for reproduction:
invalid.zip (170 Bytes)
Assuming a simple try-catch would workaround this, but not sure if there is better solutions, like some global or shared error handlers

2

Let me check that :slight_smile:

3

Add a try catch to protect from invalid data by deltakosh · Pull Request #15187 · BabylonJS/Babylon.js (github.com)

4

Validated the catch working on Babylon.js Sandbox - View glTF, glb, obj and babylon files , but the raw error got ignored, should it be kept as args of onError callback, or logged?

5

My assumption was that the error will be logged by the throw but now I’m second guessing myself

6

Wanna do a PR to add it to the error callback?

7

Well, I mean this catch here:

The error being catched here is never logger, nor passed to onError, so users or devs can only know about the model being loaded is not right, but not exactly where went wrong, which in my example invalid model, is the JSON.parse error.