[SOLVED] Unexpected light gizmo on right hand system

Questions
1

Hello, I’m new bee of this framework. I met some problem about this:
https://playground.babylonjs.com/#Z4ZGAY#3

you can find the question when you rotate the gzimo about directional light. The direction is obviously wrong in right hand system.

2

Hey!
The vector3 in the light constructor is a direction. It cannot be (0, 0, 0):
https://playground.babylonjs.com/#Z4ZGAY#4

3

OK. I will fixed it in my code. But you can see that the direction is different between left hand system & right hand system.
You can try to disable the comment of ‘scene.useRightHandSystem’, then observe the gizmo’s direction.

4

Oh yeah…unfortunately gizmos are not designed for right handed
Pinging @Cedric to see if he can have a look:)

5

I’m taking a look.

6

Actually, I’m wondering if the issue is with the gizmo.
1st screen: Left Hand coordinates. Sphere.position.x = -1 is on the left.Light vector is (1.,0,0). Light comes from the left goes to right. Sphere lighting and lightmesh orientation are fine.

image
image.png1160×880 35.3 KB

Coordinates changed to right hand.

image
image.png1122×857 34.5 KB

And now we have the issue. Sphere is now on the right. Light mesh gizmo goes for the right to the left but the sphere directional lighting is the same as before.

So, this looks like the gizmo is fine but the directional light is wrong. Can you confim @Deltakosh ?

7

oh right!! This is a light issue
Good catch! Can you have a look at it?

8

Sure! I’m on it

1 Like
9

And the corresponding PR Fix Right Hand coordinates with directional lights and shadows by CedricGuillemet · Pull Request #6712 · BabylonJS/Babylon.js · GitHub

10

Thx @Cedric & @Deltakosh.
Hope new version will finish as soon as possible.

11

Hi, @Cedric & @Deltakosh.
The spot light has the same question.

12

Argh! I didn’t forget to check the shadow but I forgot to test the spotlight.

1 Like
13

@Cedric

when you attach the light Gizmo, the light’s direction will be set to negative.
I found solution as following:

public set light(light: Nullable<Light>) {
    if ((light as any).direction) {
        const direction = (light as any).direction.clone() as Vector3;
        if (this.light.getScene().useRightHandedSystem) {
            direction.x = -direction.x;
            direction.y = -direction.y;
            direction.z = -direction.z;
        }
        this.attachedMesh!.setDirection(direction);
    }
}
1 Like
14

It is already fixed in the preview branch

1 Like
15

Thx!!!

16

I found a new bug for the RH.
When you attach the Gizmo, there is no problem. However, if you do not attach it, it present like LH.
I have been try in my code, while PG’s bug not fixed.

1 Like
17

pinging @Cedric

18

I’m taking a look