WebGPU use glsl bug ： non-opaque uniforms outside a block

jinjun199403 · August 3, 2023, 7:35am

switch to WebGPU

jinjun199403 · August 3, 2023, 7:45am

uniform is not supported instead of uniform block? · Issue #1452 · KhronosGroup/glslang

jinjun199403 · August 3, 2023, 7:48am

some uniform can’t convert to uniform LeftOver:

Evgeni_Popov · August 3, 2023, 12:18pm

Thanks for reporting, here’s the fix:

jinjun199403 · August 4, 2023, 3:36am

@Evgeni_Popov Thank you very much, but other problems have arisen.

jinjun199403 · August 4, 2023, 6:47am

bug in this line :recognizes the in in origin

vec3 origin = vec3(0.0);

jinjun199403 · August 4, 2023, 8:17am

github.com/BabylonJS/Babylon.js

Implement word boundary checks in regular expressions

BabylonJS:master ← jinjun1994:Parsing-of-GLSL-shaders-in-WebGPU-Fix-detection-of-varyings

opened 08:14AM - 04 Aug 23 UTC

jinjun1994

+3 -3

In the current implementation of regular expressions intended to match the GLSL …keywords "in", "out", and "varying", it has been found that the patterns may match parts of variable names or within comments that contain these keywords, leading to inaccurate results. To improve accuracy, word boundaries (\b) have been applied around each keyword in the regular expressions. This ensures that the engine would only match complete words, not substrings within longer words or comments. The regular expressions have been updated as follows: ```` const outRegex = /(flat\s)?\s*\bout\b /; const inRegex = /(flat\s)?\s*\bin\b /; const varyingRegex = /(flat\s)?\s*\bvarying\b/ ; ```` While this improves the keyword matching accuracy, please note that particularly advanced cases like keyword usage inside comments might still not be handled perfectly. For deeper parsing needs, consider using a dedicated GLSL parser or compiler plugin.

I’ve fixed it. Please review. @Evgeni_Popov

Topic		Replies	Views
How to use GLSL uniform struct with WebGPU Questions webgpu	8	397	April 26, 2024
Uniform arrays with non uniform control texture sample (WebGPU) Bugs shader , webgpu , glsl	21	724	December 14, 2023
Texture sampler and non uniform control flow Questions shader , webgpu , postprocessing	3	617	June 1, 2024
Compilation errors Bugs	3	251	September 8, 2023
PBRCustomMaterial shader fails to compile only when using WebGPU Questions	4	367	July 4, 2023

WebGPU use glsl bug ： non-opaque uniforms outside a block

Related Topics