Major drop of FPS when upgrading beta.2 to beta.3

can you repro with something in he playground?

Not really, it’s a pretty complex scene, but I can deploy a version that this slow down happens so you can inspect it your self, will it help?
Anyway, I kept on digging and found an interesting thing while inspecting performance on iOS (iPhone s7, safari):

Ok I’ll try something
Can you get the next nightly (in a hour or so) and test it?

1 Like

Sure! how do I do that? (I’m using the ES6 version)

well I cannot deploy a npm update so you will have to use the preview.babylonjs.com/babylon.js file directly

(maybe just copy paste it in your node-modules folder where the current one is)

I’m using the ES6 version and transpile the module with webpack while compiling, so I assume that using this version will require lots of changes that might be relevant to this issue. (and will take a while)
Do you think I will be able to build my own version of @babylon/core and use this version (don’t mind to copy paste it just to check if it’s working)? I can’t think of an easier option.

Thanks again!

try to go to babylonjs/core/engines forlder in your es6 npm folder and replace this file:
engine.zip (41.5 KB)

1 Like

Thanks!
Tried that, but didn’t work.
I’m running rc.2 now hope that’s what you expected.

  • Made sure that the new code is deployed (deployed a version with console.log in engine.js and saw it printed)
  • Made a text comparison of rc.2 engine.js and the file you sent and changed to:
                    var offset = data.byteOffset + byteOffset;
                    if (offset || byteLength !== data.byteLength) {
                        data = new Uint8Array(data.buffer, offset, byteLength);
                    } else {
                        console.log('hello!@#!@#@#');
                    }

to make sure there is any effect to the changes you’ve made, and didn’t see any logs.

here are two fresh snapshots I took:
chrome mobile on galaxy S10:

safari on iPhone s7:

crap this is not the content you should have.
my version has no if (offset…

I’m publishing a RC for you (RC3)
will be up in 10 minutes or so

it is live

Thanks again!

Tried it now, and I don’t see any change.

I’m trying to investigate this issue on my end as well, but I don’t see any reason for the drop of FPS.
I don’t think it’s something related to the specific versions I specified, maybe something related to the compilation process of the app (webpack + transpile-modules for @babylon/core & @babylon/gui), cause the thing I see now is that sometimes when I compile the app I see this problem across different browsers and devices and sometimes don’t. and it’s very consistent, when the version is “slower” it’s always slower doesn’t matter which device, and when it’s fine it’s always working.

Here are new snapshots I took:
28


Well I really need a repro in the PG to help. The profiler is SO weird

pinging @Sebavan FYI

It will be extremely hard to repro in PG cause that’s kinda entire app to recreate in PG.
What if I deploy 2 versions of my app?(slower version and normal version) to different hosts so you can see for yourself? will it help?

Thanks once again :slight_smile:

Yes but trying to repro in the PG will help you narrow down the problem. It is almost impossible to help with all your codebase around

Anyway we can still try to see if there is something obvious

O.K thanks, I’ll try to do both

Could you provide me by PM an access to your app, I would like to double check it before the release.

Sure!
Thank you guys you’re awesome, I know that I messed it up before, but now I’m certain that the problematic version is beta.4, meaning - beta.3 still working.
It was pretty confusing to check it, every time I need to change babylon version, reinstall modules, build the app, run it and check the app on my phone, the entire process takes 10 min or so… Anyway this time just to be sure I checked it around 6-7 times, installed beta.3 performance are great, installed beta.4 and again the FPS drops.

So now I wanna deploy 2 versions of my app that only differs by babylon version so you guys can see it for yourself, that’s quite a lot of work so I assume it will be ready in few hours.

Thanks once again :slight_smile:

1 Like

Solved in 4.0.0! :partying_face: