Mark implicitly created material plugins doNotSerialize by default

kzhsw · September 1, 2025, 2:16am

In recent versions 2 implicitly created material plugins added, DepthSensingMaterialPlugin, and TAAJitterMaterialPlugin

github.com/BabylonJS/Babylon.js

packages/dev/core/src/XR/features/WebXRDepthSensing.ts

d78c12fb7


      
          

          WebXRFeaturesManager.AddWebXRFeature(

              WebXRDepthSensing.Name,

              (xrSessionManager, options) => {

                  return () => new WebXRDepthSensing(xrSessionManager, options);

              },

              WebXRDepthSensing.Version,

              false

          );

          

          RegisterMaterialPlugin("WebXRDepthSensingMaterialPlugin", (material) => new WebXRDepthSensingMaterialPlugin(material));

github.com/BabylonJS/Babylon.js

packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/taaMaterialManager.ts

d78c12fb7


      
          /** @internal */
          public readonly _materialPlugins: TAAJitterMaterialPlugin[] = [];
          
          /**
           * @param scene All materials in this scene will have a jitter offset applied to them.
           */
          constructor(scene: Scene) {
              for (const material of scene.materials) {
                  this._getPlugin(material);
              }
              RegisterMaterialPlugin(TAAJitterMaterialPlugin.Name, (material) => this._getPlugin(material));
          }
          
          /**
           * Disposes of the material manager.
           */
          public dispose(): void {
              UnregisterMaterialPlugin(TAAJitterMaterialPlugin.Name);
              const plugins = this._materialPlugins.splice(0, this._materialPlugins.length);
              for (const plugin of plugins) {
                  plugin.manager = null;

Material plugins with RegisterMaterialPlugin are created in constructor, which is far before serialized material plugin parsed

github.com/BabylonJS/Babylon.js

packages/dev/core/src/Materials/material.ts

d78c12fb7


      
              protected static _ParsePlugins(serializationObject: any, material: Material, scene: Scene, rootUrl: string) {

                  if (!serializationObject.plugins) {

                      return;

                  }

          

                  for (const pluginClassName in serializationObject.plugins) {

                      const pluginData = serializationObject.plugins[pluginClassName];

          

                      let plugin = material.pluginManager?.getPlugin(pluginData.name);

          

                      if (!plugin) {

                          const pluginClassType = Tools.Instantiate("BABYLON." + pluginClassName);

                          if (pluginClassType) {

                              plugin = new pluginClassType(material);

                          }

                      }

          

                      plugin?.parse(pluginData, scene, rootUrl);

                  }

              }

          }

And since they are not parsed since they are already created via constructor event, there is no need to be serialized, so it should be doNotSerialize by default.

Also, why would this kind of implicitly created material plugins needed since plugins are already allowed to be created at runtime? Is there any chance that all those implicitly creation of material plugins removed, and only be created when needed?

Evgeni_Popov · September 1, 2025, 8:23am

Regarding TAA, the plugin is injected only if TAA is used, so we should be ok. You’re right regarding the WebXR depth sensing plugin, it should be injected only if this feature is used:

I also added the doNotSerialize flag.

Thanks for the feedback!

Topic		Replies	Views
doNotSerialize for material plugins Completed Features serialization , materialpluginbase	5	60	December 10, 2024
Material.clone() doesn't clone all material plugins Bugs material-plugin	15	572	April 10, 2025
Scene serialisation and deserialisation doesn't work when material plugin is used Questions material	1	85	February 6, 2024
Potential memory leak with `managedMaterialPlugins` Bugs memory	6	41	April 3, 2025
Using the material plugin to report an error Questions material	5	288	August 2, 2023

Mark implicitly created material plugins doNotSerialize by default

Related topics