Shader review for purpose of custom frame and opensource

Content creation (3dsMax, Maya, Blender, glTF)
1

I looked at the shader custom frames and there are a number of items I would like but that is not there.
So I am creating those I need with the plan to add them to the existing repo of custom frames (if permitted)

Would love to have a review on the shader/s before committing it.
The aim is to make sure the shader is following best practice and performance before make it open for public use.

For now it’s just simple shapes but if you know shaders and can help with reviews and review comments I would appreciate it.

This is a example of what I am talking about.

What is the expected procedure for contributing to assets in the babylonjs repo?

2

You can simply create a PR to the repo there and would be great with an example in the PR so we can review all of it :slight_smile: Thanks a lot

2 Likes