Hi, I’ve upgraded to the latest release 5.0.0-alpha.65, and am encountering some errors in the console, output from Effect._processCompilationErrors
Weirdly, the html of my page is shown in the output of the vertex code. Not sure if this is a bug or something that’s changed that I need to fix in the new version/s, my app worked fine in bjs 4.
Yup this is like the RGBDPostProcess shader is not part of your package for some reasons … I can not think about why If you can share a git repo or equivalent I can have a look
Is there some file that has the side effect of adding the shaders to the shaderstore? I tried to dig into the code but couldn’t find where this is done. The shaders themselves seem to be included, a breakpoint I set inside the generated rgbdDecode.fragment.js is being hit.
The shader store only has 4 shaders, which doesn’t seem quite right:
I’m also getting the same issue with the following shaders:
w000t this is strange cause if you have a pbr material in your scene this import "@babylonjs/core/Materials/PBR/pbrBaseMaterial" should happen for you but I am glad it is working now.
If I recall correctly (a pretty big if) I have a peer dependency which was code split at the time. For whatever reason, side effects would / wouldn’t take effect depending on whether I imported them inside the peer dependency or my main codebase.
I never really got to the bottom of it but try moving the imports around - writing it out sounds like it was an ordering issue
Had another ShaderStore issue and got to the bottom of it this time.
I have a dependency which has a peerDependency of babylon in its package.json. My main package also has babylon as a dependency. Babylon was installed in the node_modules folder of both my main package and the dependency. This meant sometimes two separate copies of the same file were being included and ran in the final build.
In this case, it was shaderStore.js from both my package and the dependency being included. This meant there were two ShaderStore objects and two ShaderStore.ShadersStore objects.
The fix was just to delete the installed babylon in my dependencies node_module’s folder which let npm always resolve to the babylon in my main package’s node_modules folder.