Cel Shading is misspelled in Babylon.js

I just started using Babylon.js, and immediately noticed that the official documentation and demos use the wrong word for “cel shading”:

https://www.babylonjs.com/demos/cellshading/

(My apologies if this is already widely known on this forum, but I don’t see any mention of it.)

Ultimately it’s not a huge deal, since it’s a very common mistake and most people know that “cell shading” really means “cel shading”, but it’s very grating to someone with long experience in 3D graphics. I mean, it’s such a common mistake that the wikipedia page even lists “cell shading” as a variant name, but since the actual name derives from “animation cel” then the more common word “cell” is clearly a mistake.

I would suggest something like changing the official material to “Cel Material” but keep “Cell Material” around for backwards compatibility, and put a note on the documentation page.

1 Like

For reference, the wikipedia pages about “cel shading” and “animation cel”:

2 Likes

Hey @jhocking - First and foremost, welcome to the Babylon family! We’re sincerely happy to have you here!

Thanks for flagging this issue. Great catch!

Before I dive in to take a look, we always like to encourage/ask folks if they’d be willing to submit a PR for it? Not the end of the world, but if you’re willing, we’d LOVE to count you as an active contributor to the project :wink:

Thanks again for flagging this!

Will do, I am semi-active on github in other projects already, I just didn’t know if a PR for this would be welcome.

gosh I just noticed this way down in my TODO list. um @PirateJC you should probably go ahead and take care of this after all, because I have no idea when I would.

2 Likes

Thanks @jhocking, we’ll figure out the best way to go about changing this in a way that preserves back-compat.

1 Like

Goblin: Hi, id like to make an arbitrary change to your spellbook. Please see my link to wikipedia referencing your naming convention as a synonym in the first line. Yours is definitely wrong.

Wizard: Hello traveler, Warmest welcome humanly possible. Would you like to add the changes?

Goblin: Na, afk. You do it, cya.

1 Like

LOL

Hahaha Not at all. We welcome ideas from all, and we totally get it, not everyone has time to contribute.

Next time!