CYOS's WebGPU Phong shader may be incorrect

Bugs
,
1

I tried the CYOS WebGPU shader.
https://cyos.babylonjs.com/
However, the execution result of WebGPU’s Phong shader seems to be too bright compared to WebGL2.

When I checked the code, it seems that specComp2 is being calculated, but it is not being used. I think that’s probably the cause.

// Specular
let angleW = normalize(viewDirectionW + lightVectorW);
let specComp = max(0., dot(vNormalW, angleW));
let specComp2 = pow(specComp, max(1., 64.)) * 2.;

//fragmentOutputs.color = vec4(color * ndl + vec3(specComp), 1.);
fragmentOutputs.color = vec4(color * ndl + vec3(specComp2), 1.);

image
image741×638 42.6 KB

image
image742×603 47.4 KB

The settings I tried are below.
TEMPLATES: Phong
MESHES: Sphere
3D API: WebGPU

2

Yup it is a bug I ll push a PR ASAP for @RaananW to deploy :slight_smile:

3

Fix is here fix webgpu phong shader · BabylonJS/CYOS@22b7d78 · GitHub

3 Likes
4

Thank you for the quick correction.
I checked the others, and it seems that there is a similar problem with “Wave”.

5

The same PR will fix it as the fragment is shared but thanks for your feedback @cx20 !!!

1 Like
6

just to update - deployed and working correctly

1 Like
7

I have confirmed that the shader is fixed.

BTW, I noticed another problem with CYOS.
I would appreciate it if you could check this as well.