No confirm when switching playground version

on playground
switch JS <=> TS - confirm shown :slight_smile:
switch BABYLONJS 5 <=> BABYLONJS 4.2 - no confirm :frowning:

no confirm = lost code sometimes

2 Likes

for UX, I think I can ping @PatrickRyan :slight_smile:

2 Likes

@nekochanoide, I agree with you. We will add a pop-up similar to the one shown when toggling languages.

1 Like

PR is up, it should be in tomorrow.

2 Likes

I am sorry. I was not clear. I forgot to mention switching between gl versions as wellโ€ฆ :frowning:
Also pop-up works only for switching from recent version to older but not other way around. I think this is not important (tho you are to decide as a specialist)
Anyways, thank you for your work. :sunglasses:

@nekochanoide, thank you for bringing up the gl version switch. That one escaped me. I also was able to repro a version change not popping a warning, but it seems a little inconsistent. I was able to get them to pop going back and forward, but there were some jumps that did not pop a warning. We will take a look to see if there is a bug in there.

@nekochanoide, there was a PR merged from @sebavan to add a warning to the WebGL/WebGL2 toggle in the playground. I continued to test the engine version selector to see if I could repro the warning dialog to not showing on switch so I could write an issue. Unfortunately, I wasnโ€™t able to repro after my last message so I am not sure if there is an underlying bug or if it was a caching issue. If you notice the dialog not showing on switch, please let us know and if you can describe how you were able to repro. I will also keep an eye on it to make sure it is working properly.

1 Like