Quaternion Conjugate two InPlace

Bugs
1

@RaananW rhe methods conjugate and conjugateInPlace for quaternions both do an in place return.

Probably conjugate was set up like normalize originally and for some reason conjugateInPlace added later.

Changing now would be a breaking change

Possible solutions

  1. add a Boolean parameter when true create a new quaternion as conjugate of current
  2. Create conjugateToNew
2

I like option 2 :slight_smile:
We could also deprecate the conjugate function and reference the conjugateInPlace, but I think that might be a little “too much” .

3

I can do a PR for option2 probably by Monday 10th Oct.

4 Likes
4

@RaananW my apologies the docs state that that is an in place method but having now checked the code it is not.

PR correction to to comments done.

2 Likes