shadowGenerators serialized without light

kzhsw · January 23, 2025, 1:49am

Background

Version: 7.44.1
Engine: any
Browser: any

Desc

There is currently no doNotSerialize option for a ShadowGenerator, and a ShadowGenerator would be serialized even if the light of it marked with doNotSerialize.

Expected

Add a doNotSerialize option to ShadowGenerator, and skip serialization if it’s true
A ShadowGenerator should not be serialized if its light is marked with doNotSerialize. (https://playground.babylonjs.com/#ZBSXNP#1)

Actual

Evgeni_Popov · January 23, 2025, 9:15am

Agree.

We will be happy to merge a PR about it!

Deltakosh · January 23, 2025, 5:07pm

agreed

kzhsw · January 24, 2025, 3:28am

github.com/BabylonJS/Babylon.js

ShadowGenerator: add doNotSerialize

BabylonJS:master ← kzhsw:patch-1

opened 02:33AM - 24 Jan 25 UTC

kzhsw

+19 -0

This PR adds doNotSerialize to `ShadowGenerator` and `IShadowGenerator` (optiona…l field for `IShadowGenerator` to avoid being breaking). Also, in `ShadowGeneratorSceneComponent` serialization of a `ShadowGenerator` would be skipped if it has `doNotSerialize=true`, or its light has `doNotSerialize=true`. This should fix <https://forum.babylonjs.com/t/shadowgenerators-serialized-without-light/56134>.

Topic		Replies	Views
Serializing Cascaded Shadow generators for FileLoader Content creation (3dsMax, Maya, Blender, glTF)	6	494	May 20, 2021
Light serialization Questions lighting	14	765	November 13, 2021
The shadow does not work with object .babylon Questions documentation , blender , lighting , material , shader	4	2010	March 7, 2019
Not able to render the shadow of the model Bugs lighting	7	663	March 23, 2020
Updating shadow generator/shadow blur for new assets/optimisation Questions	5	1188	October 2, 2020

shadowGenerators serialized without light

Background

Desc

Expected

Actual

Related topics