shadowGenerators serialized without light

kzhsw · January 23, 2025, 1:49am

Background

Version: 7.44.1
Engine: any
Browser: any

Desc

There is currently no doNotSerialize option for a ShadowGenerator, and a ShadowGenerator would be serialized even if the light of it marked with doNotSerialize.

Expected

Add a doNotSerialize option to ShadowGenerator, and skip serialization if it’s true
A ShadowGenerator should not be serialized if its light is marked with doNotSerialize. (https://playground.babylonjs.com/#ZBSXNP#1)

Actual

Evgeni_Popov · January 23, 2025, 9:15am

Agree.

We will be happy to merge a PR about it!

Deltakosh · January 23, 2025, 5:07pm

agreed

kzhsw · January 24, 2025, 3:28am

github.com/BabylonJS/Babylon.js

ShadowGenerator: add doNotSerialize

BabylonJS:master ← kzhsw:patch-1

opened 02:33AM - 24 Jan 25 UTC

kzhsw

+19 -0

This PR adds doNotSerialize to `ShadowGenerator` and `IShadowGenerator` (optiona…l field for `IShadowGenerator` to avoid being breaking). Also, in `ShadowGeneratorSceneComponent` serialization of a `ShadowGenerator` would be skipped if it has `doNotSerialize=true`, or its light has `doNotSerialize=true`. This should fix <https://forum.babylonjs.com/t/shadowgenerators-serialized-without-light/56134>.

Topic		Replies	Views
colorShader and colorShaderOccQuery kept after serialize Bugs material , sceneserializer , serialization , serializer , boundingbox	1	511	December 26, 2022
CascadedShadowGenerator not working but regular ShadowGenerator works Questions shadows , shadowgenerator	3	770	December 29, 2021
Issue with a spotlight Questions	7	712	April 12, 2023
When the model transparency is less than 1, the shadow will disappear Questions	1	135	January 2, 2024
ShadowGenerator issue Questions	3	409	September 15, 2020

shadowGenerators serialized without light

Background

Desc

Expected

Actual

Related topics