Pay attention to your body’s signals, Roland. Get well soon! 
1 Like
It must be because uniform buffers are not supported on your system, so you should make sure that the “fragment” section of getUniforms is correct.
For eg, in this PG, it is:
getUniforms() {
return {
"ubo": [
{ name: "myColor", size: 3, type: "vec3" },
],
"fragment":
`#ifdef COLORIFY
uniform vec3 myColor;
#endif`,
};
}
All uniforms that appear in the “ubo” section should also be defined in the “fragment” section.
1 Like
Guys, @RaananW,
how can I ensure that my tree shakeable single functions from Misc/greasedLineTools.ts are put not directly under the BABYLON namespace, but under BABYLON.GreasedLineTools?
EDIT: I’ve tried namespacing the functions or export * as GreasedLineTools from “./greasedLine” in index.ts but I could get it working in Playground. Actually it was OK, just the intellisense didn’t work 
EDIT: If i don’t use class methods I don’t get intellisens at all:
1 Like
Guys,
I think I am ready for the first PR. However the intellisense issue is still a thing. Should I refactor to static class methods?
Thanks!
EDIT: I need to be hospitalized for a few days. I started to feel better, but today suddenly I started to feel much worse, I was at the doctors in the morning and just got a call from the doc that I’ve a bacterial infection of the respiratory system and that sucker seems to ATB resistent + I was COVID possitive… So… Fuck me dead… I’ll hopefully get back alive on Tuesday 
Just to be sure, current sources:
5 Likes
Ohhhhh just seen the edit… feel better soon @roland !!!
@RaananW will be able to have a look soon for the API.
2 Likes
quit smoking, get some snus or dip, works better anyway
2 Likes
Yep, I’ll check this weekend or beginning of next week
1 Like
Hello, I am back and I feel much better! Thanks guys!
4 Likes
Helllo!
I didn’t create a PR yet. Can you please check my previous posts about the intellisense issue?
Thanks!
to ge tthe typing in UMD you will need to export your class and functions from a referenced index.ts. To allow tree-shaking in es6 you just need to be sure to not reference those functions from any other class.
But i’ll really need to see some code (if possible) to recommend the best way to go here.
Ok, so I’ll create a PR and I think together we will polish it to perfection 
2 Likes
Hello!
Just by converting the standalone functions to public static methods of a class intellisense started to work:
Serialization is not working perfectly, I need to fix some issues. I will create the PR when it’s done.
2 Likes
@RaananW @sebavan @Deltakosh @Evgeni_Popov
Guys!
Finally:
I’ve added a dozens of TODO’s to the source code, so there is still work to do (only small changes or things I wasn’t sure of) . I have created PGs (#406E3H up to #16) with code to test GreasedLine but I will create new ones (basically all of this https://greased-line.babylonjs.xyz/ with comments so I can use them in the docs as well).
@RaananW what’s next? Honestly I am pretty nervous my first big contribution…
I am so relieved that finally I made it to the first PR! 
So guys, let me know please, what are the next steps.
Thank you!
4 Likes
Label added, i reviewed the structure (without diving too much into the code yet), and - it seems to be working, in general 
Babylon.js Playground (babylonjs.com)
oh, and.,… thank you so much for this PR!!!
2 Likes
Cool! 
Guys, you are very welcome! I’ve some ideas for new features already and I’m looking forward to have the PR closed so I can start to work on them.
I am already working on the PG’s for the docs and I’ve discovered a bug I must’ve introduced these days. When updating the points offsets something strange is happening and the whole line is flickering. Already working on it.
I’ll be off until next Monday. Waiting for inputs from your side
Here are some basic lines with color, color tables, width tables, offset tables: #B2R6RJ
2 Likes
@roland it is getting there !!! the first big 7.0 feature !!! Congrats !!!
2 Likes
I was about to mention it!!! Welcome to the hero features of 7.0:)
2 Likes