PBR _imageProcessingConfiguration Parse Regression after 8.28.2

kzhsw · March 18, 2026, 6:52am

Version: 8.28.2~8.55.3

Steps to repro:

Open this playground at 8.28.2 (or any version after that)
https://playground.babylonjs.com/?version=8.28.2#XH0PW9#7
Compare it with 8.28.1
https://playground.babylonjs.com/?version=8.28.1#XH0PW9#7

Expected:

Actual:

Possible related changeset:

Reference:

kzhsw · March 18, 2026, 7:28am

Possible fix:

github.com/BabylonJS/Babylon.js

ImageProcessingMixin: correctly invoke decorator factory (#18126)

master ← kzhsw:patch-3

opened 07:27AM - 18 Mar 26 UTC

kzhsw

+1 -1

`serializeAsImageProcessingConfiguration` is a decorator factory — it returns a …decorator function. The call chain is: 1. `serializeAsImageProcessingConfiguration(sourceName?)` → returns `(target, propertyKey) => { ... }` 2. The `.call(this, this, "_imageProcessingConfiguration")` invokes the factory with `sourceName = this` (an object, not a string) 3. The returned decorator function is never invoked — it's just a discarded return value The correct code should be: ``` serializeAsImageProcessingConfiguration()(this, "_imageProcessingConfiguration"); // ^^ call factory to get decorator, THEN invoke decorator ``` Or equivalently: ``` const decorator = serializeAsImageProcessingConfiguration(); decorator(this, "_imageProcessingConfiguration"); ``` The result: _imageProcessingConfiguration is NOT registered in the DecoratorInitialStore. When `SerializationHelper.Parse()` processes a `.babylon` file, it doesn't find the property in the store, so the serialized image processing configuration (exposure, contrast, tone mapping, color curves, etc.) is silently ignored. The material falls back to the scene's default image processing configuration. Before 8.29.0 (commit ca70334958), PBRBaseMaterial had: ``` @serializeAsImageProcessingConfiguration() protected _imageProcessingConfiguration: ImageProcessingConfiguration; ``` This properly registered the property for serialization/deserialization. This commit should fix the parse regression since release 8.28.2, and following forum bugs: - <https://forum.babylonjs.com/t/pbr-imageprocessingconfiguration-parse-regression-after-8-28-2/62831> - <https://forum.babylonjs.com/t/the-same-pg-and-the-same-texture-produce-different-results-in-different-versions/62829>

Fixed now in 8.55.4:

kzhsw · March 18, 2026, 9:38am

Oh, wait, if the constructor not called (a fresh scene / engine is initialized), the decorator would still not be registered, so feel free to close that PR and make a better resolution, or go the naive way that manually adds decorator for every subclass of ImageProcessingMixin
It’s safe to use the constructor, as the constructor will be called in SerializationHelper.Parse before ParseProperties, so in ParseProperties it should be already added.

Topic		Replies	Views
The same PG and the same texture produce different results in different versions Bugs	3	36	March 18, 2026
Problem when parsing pbr and environment textures Bugs pbr , environment	7	664	June 23, 2021
PBR materials image processing configuration not cloned Bugs material	2	24	January 8, 2025
Option to include textures in .babylon files Feature requests sceneserializer	28	3246	September 28, 2020
Bug when assign new image processing to material Bugs	4	36	May 19, 2025

PBR _imageProcessingConfiguration Parse Regression after 8.28.2

Related topics